fastrpc_test: DSP autolink, guarded timeout wrapper, and SKIP semantics for missing binary#180
Merged
abbajaj806 merged 1 commit intoqualcomm-linux:mainfrom Oct 3, 2025
Merged
Conversation
Introduce a portable, idempotent autolink step that populates /usr/lib/dsp
from /usr/share/qcom/**/dsp only when /usr/lib/dsp is empty.
Key points
- No SoC hardcoding: discovers all /usr/share/qcom/**/dsp candidates and
picks the best match using platform hints (detect_platform if present)
or falls back to the most populated candidate.
- Yocto-safe, sudo-free: requires root; if filesystem is read-only,
optionally remounts rw when FASTRPC_AUTOREMOUNT=yes and restores ro
unless FASTRPC_AUTOREMOUNT_RO=no.
- Idempotent & safe: skips when /usr/lib/dsp already has entries; does
not clobber existing files; links files only; warns instead of failing
if linking isn’t possible.
- Configurable knobs:
* FASTRPC_DSP_AUTOLINK=yes|no (default: yes)
* FASTRPC_DSP_SRC=/path/to/dsp (force a specific source)
* FASTRPC_AUTOREMOUNT=yes|no (default: no)
* FASTRPC_AUTOREMOUNT_RO=yes|no (default: yes)
- Clean helpers: no underscores in helper function/var names to match
repo style; pure POSIX sh.
- Placement: autolink runs once before LD_LIBRARY_PATH and
*DSP_LIBRARY_PATH exports; logging via functestlib.
This makes fastrpc_test robust across Kodiak/LeMans/Monaco/Agatti/Talos
and future targets without per-SoC maintenance while keeping tests
non-fatal when DSP assets are missing or the FS is read-only.
Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Chennak-quic
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the enhancements that were requested as of now #179
Why
What changed (high level)
Environment knobs
User-visible behavior